Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backward compatibility for height + notice #1412

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

bynect
Copy link
Member

@bynect bynect commented Dec 10, 2024

As solicited by @stapelberg in the discussions this will be a (temporary) solution for backward compatibility of height.
This will not make it into v2, but for now is fine.
I will need to release a 1.12.1 anyway due to the graphical bug #1406

@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 47.61905% with 11 lines in your changes missing coverage. Please review.

Project coverage is 65.08%. Comparing base (162fc27) to head (f753e67).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/option_parser.c 28.57% 10 Missing ⚠️
src/utils.c 85.71% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1412      +/-   ##
==========================================
- Coverage   65.12%   65.08%   -0.04%     
==========================================
  Files          50       50              
  Lines        8654     8670      +16     
  Branches     1023     1025       +2     
==========================================
+ Hits         5636     5643       +7     
- Misses       3018     3027       +9     
Flag Coverage Δ
unittests 65.08% <47.61%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fwsmit
Copy link
Member

fwsmit commented Dec 10, 2024

Thank you for making the change for compatibility. I agree with the users that making the configuration backward compatible is very important. I would even suggest to keep the current configuration working for version 2, since it would cause a lot of work for users to move their configuration over to the new version. Instead you could maybe add a version specifier to the configuration file like "#dunst config V2" and only fix the inconsistencies there.

@bynect
Copy link
Member Author

bynect commented Dec 10, 2024

I would even suggest to keep the current configuration working for version 2

well, if there are some backward incompatible changes to be made it has to be a major revision.
I think that if a few changes to the config will be needed by v2 this can be added to the bucket.
But we'll see when time comes

@stapelberg
Copy link
Contributor

Thank you for making this change! This will save time for many users, I expect :)

@bynect bynect merged commit d318dde into dunst-project:master Dec 10, 2024
23 checks passed
@fwsmit
Copy link
Member

fwsmit commented Dec 10, 2024

I would even suggest to keep the current configuration working for version 2

well, if there are some backward incompatible changes to be made it has to be a major revision.
I think that if a few changes to the config will be needed by v2 this can be added to the bucket.
But we'll see when time comes

Well see yeah. For now i think its good to just bring a new release with these fixes

@bynect
Copy link
Member Author

bynect commented Dec 10, 2024

I would even suggest to keep the current configuration working for version 2

well, if there are some backward incompatible changes to be made it has to be a major revision.
I think that if a few changes to the config will be needed by v2 this can be added to the bucket.
But we'll see when time comes

Well see yeah. For now i think its good to just bring a new release with these fixes

I want to fix one last thing than I can make 12.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants