Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-design hades permutation #243

Closed
moCello opened this issue Jan 19, 2024 · 3 comments · Fixed by #244
Closed

Re-design hades permutation #243

moCello opened this issue Jan 19, 2024 · 3 comments · Fixed by #244

Comments

@moCello
Copy link
Member

moCello commented Jan 19, 2024

Summary

Expose only permute and permute_gadget functions (and WIDTH) from hades module.
Edit: After a comment from @xevisalle we decided to only expose the WIDTH from the hades module to the public API.

With this change we can refactor the permutation designs internally without a breaking change, if desired, in the future.

@moCello moCello changed the title Refactor hades permutation Re-design hades permutation Jan 19, 2024
moCello added a commit that referenced this issue Jan 22, 2024
moCello added a commit that referenced this issue Jan 22, 2024
@moCello
Copy link
Member Author

moCello commented Jan 22, 2024

Following up the comment from #242 (comment)
@xevisalle do you think the entire permutation functions should better be private?

@xevisalle
Copy link
Member

Following up the comment from #242 (comment) @xevisalle do you think the entire permutation functions should better be private?

will someone ever want to use hades without poseidon? as it is optimized for our implementation, and now it is even part of the poseidon crate, I guess it's unlikely to happen. In the future we can set public functions to change Hades configurations, but by now I would keep it private.

@moCello
Copy link
Member Author

moCello commented Jan 22, 2024

I agree. I'll only expose the WIDTH then.

moCello added a commit that referenced this issue Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants