Move hades permutation into poseidon lib #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moCello
force-pushed
the
mocello/240_hades
branch
from
f5377c8
to
2eeb49c
Compare
xevisalle
approved these changes
Jan 22, 2024
| @@ -18,3 +18,6 @@ pub mod perm_uses; | |||
|
|
|||
| /// Implementation for the Poseidon Sponge hash function | |||
| pub mod sponge; | |||
|
|
|||
| /// Implementation of the Poseidon permutation based on the Hades strategy | |||
| pub mod hades; | |||
There was a problem hiding this comment.
That is indeed debatable! For this PR I wanted to simply port everything from hades without doing a lot of changes and since the crate was public, I though it makes sense to make the hades module in our poseidon library public as well. I opened an issue to only expose two permutation functions (one normal and the gadget) and the hades WIDTH #243
There was a problem hiding this comment.
I'll merge this PR and we continue the discussion in #243
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #240