Implement Zeroize for SecretKey
#158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moCello
force-pushed
the
mocello/155_zeroize
branch
from
3ab3073
to
cb31fa7
Compare
Resolves #155
moCello
force-pushed
the
mocello/155_zeroize
branch
from
cb31fa7
to
cba22af
Compare
ureeves
approved these changes
Apr 24, 2024
Comment on lines
-80
to
-85
| impl From<SecretKey> for ViewKey { | ||
| fn from(sk: SecretKey) -> Self { | ||
| Self::from(&sk) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
That's quite the catch on the by-copy. Nice
There was a problem hiding this comment.
indeed! Will have some ripple effects downstream, but good ones!
Daksh14
reviewed
Apr 24, 2024
| /// | ||
| /// To ensure that no secret information lingers in memory after the variable | ||
| /// goes out of scope, we advice calling `zeroize` before the variable goes out | ||
| /// of scope. |
There was a problem hiding this comment.
Would implementing Drop and calling zeroize there solve this problem?
There was a problem hiding this comment.
Sadly not. I investigated the problem in our bls signature library: dusk-network/bls12_381-bls#6
long story short: rust still often copies values internally, so the zeroize on drop often doesn't result in actually erasing the desired values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #155