Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI Workflow for Building the Toolchain #17

Open
wants to merge 1 commit into
base: dusk
Choose a base branch
from

Conversation

d-sonuga
Copy link

@d-sonuga d-sonuga commented Jan 8, 2025

For #16.

There are three problems with the current CI workflow for building the toolchain:

  • Changes made in the compiler's bootstrapping code require a git remote that points to rust-lang/rust present in CI builds.
  • Only 16 commits are fetched. This is a problem because, in the compiler's bootstrap code, getting the right version of LLVM requires a retrieval of a git SHA, and getting this SHA requires a retrieval of the merge-base of the local rust repo and the upstream rust repo. The merge-base could be arbitrarily far in the git history, requiring a need to fetch the entire history.
  • The default C compiler toolchain on macOS doesn't have a wasm target.

This PR resolves these problems by adding code to:

  • Add a git remote that points to rust-lang/rust.
  • Fetch the entire git history instead of just 16 commits.
  • Install LLVM and use its clang and ar to compile on macOS instead of the default tools.

@d-sonuga d-sonuga force-pushed the fix-build-workflow branch from 0966621 to 308d50f Compare January 9, 2025 14:52
@d-sonuga d-sonuga requested a review from miloszm January 9, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant