Add: topic check for all deploys (#8963)

* Add: topic check for all deploys * Fix show start message and failure message in the same thread with blocked status * Let it go if the slack api fails * Add: better slack msg
dust-tt · Nov 28, 2024 · 484cb00 · 484cb00
1 parent f352f8e
commit 484cb00
Showing 9 changed files with 73 additions and 8 deletions.
diff --git a/.github/actions/slack-check-deployment-blocked/action.yml b/.github/actions/slack-check-deployment-blocked/action.yml
@@ -11,6 +11,10 @@ inputs:
   slack_token:
     description: 'Slack bot token'
     required: true
+outputs:
+  blocked:
+    description: "Is deployment blocked?"
+    value: ${{ steps.parse_channel_topic.outputs.blocked }}
 
 runs:
   using: "composite"
@@ -23,7 +27,6 @@ runs:
         token: ${{ inputs.slack_token }}
         payload: |
           channel: ${{ inputs.channel }}
-        errors: true
 
     - name: Get channel topic
       if: steps.slack_channel_info.outputs.ok == 'true'
@@ -58,8 +61,10 @@ runs:
 
         if is_blocked "${{ inputs.component }}" "${{ steps.slack_channel_topic.outputs.topic }}"; then
             echo "${{ inputs.component}} is blocked based on channel topic"
+            echo "blocked=true" >> $GITHUB_OUTPUT
             exit 1
         else
             echo "${{ inputs.component}} is not blocked based on channel topic"
+            echo "blocked=false" >> $GITHUB_OUTPUT
             exit 0
         fi
diff --git a/.github/actions/slack-notify/action.yml b/.github/actions/slack-notify/action.yml
@@ -20,6 +20,9 @@ inputs:
   slack_token:
     description: 'Slack bot token'
     required: true
+  blocked:
+    description: 'Is deployment blocked?'
+    required: false
 
 outputs:
   thread_ts:
@@ -91,4 +94,5 @@ runs:
           thread_ts: "${{ inputs.thread_ts }}"
           text: |
             ❌ Build pipeline failed
+            ${{ inputs.blocked == 'true' && format('Is blocked by channel topic: {0}', inputs.blocked) }}
             • Check logs: <${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}|View details>
diff --git a/.github/workflows/deploy-connectors.yml b/.github/workflows/deploy-connectors.yml
@@ -34,6 +34,14 @@ jobs:
           channel: ${{ secrets.SLACK_CHANNEL_ID }}
           slack_token: ${{ secrets.SLACK_BOT_TOKEN }}
 
+      - name: Slack Check Deployment Blocked
+        id: check_deployment_blocked
+        uses: ./.github/actions/slack-check-deployment-blocked
+        with:
+          component: "connectors"
+          channel: ${{ secrets.SLACK_CHANNEL_ID }}
+          slack_token: ${{ secrets.SLACK_BOT_TOKEN }}
+
       - name: "Authenticate with Google Cloud"
         uses: "google-github-actions/auth@v1"
         with:
@@ -84,6 +92,7 @@ jobs:
         uses: ./.github/actions/slack-notify
         with:
           step: "failure"
+          blocked: ${{ steps.check_deployment_blocked.outputs.blocked }}
           component: "connectors"
           image_tag: ${{ steps.short_sha.outputs.short_sha }}
           channel: ${{ secrets.SLACK_CHANNEL_ID }}

diff --git a/.github/workflows/deploy-core.yml b/.github/workflows/deploy-core.yml
@@ -34,6 +34,14 @@ jobs:
           channel: ${{ secrets.SLACK_CHANNEL_ID }}
           slack_token: ${{ secrets.SLACK_BOT_TOKEN }}
 
+      - name: Slack Check Deployment Blocked
+        id: check_deployment_blocked
+        uses: ./.github/actions/slack-check-deployment-blocked
+        with:
+          component: "core"
+          channel: ${{ secrets.SLACK_CHANNEL_ID }}
+          slack_token: ${{ secrets.SLACK_BOT_TOKEN }}
+
       - name: "Authenticate with Google Cloud"
         uses: "google-github-actions/auth@v1"
         with:
@@ -84,6 +92,7 @@ jobs:
         uses: ./.github/actions/slack-notify
         with:
           step: "failure"
+          blocked: ${{ steps.check_deployment_blocked.outputs.blocked }}
           component: "core"
           image_tag: ${{ steps.short_sha.outputs.short_sha }}
           channel: ${{ secrets.SLACK_CHANNEL_ID }}

diff --git a/.github/workflows/deploy-front-edge.yml b/.github/workflows/deploy-front-edge.yml
@@ -19,13 +19,6 @@ jobs:
       - name: Checkout code
         uses: actions/checkout@v3
 
-      - name: Slack Check Deployment Blocked
-        uses: ./.github/actions/slack-check-deployment-blocked
-        with:
-          component: "front-edge"
-          channel: ${{ secrets.SLACK_CHANNEL_ID }}
-          slack_token: ${{ secrets.SLACK_BOT_TOKEN }}
-
       - name: Get short sha
         id: short_sha
         run: echo "short_sha=$(git rev-parse --short HEAD)" >> $GITHUB_OUTPUT
@@ -40,6 +33,14 @@ jobs:
           channel: ${{ secrets.SLACK_CHANNEL_ID }}
           slack_token: ${{ secrets.SLACK_BOT_TOKEN }}
 
+      - name: Slack Check Deployment Blocked
+        id: check_deployment_blocked
+        uses: ./.github/actions/slack-check-deployment-blocked
+        with:
+          component: "front-edge"
+          channel: ${{ secrets.SLACK_CHANNEL_ID }}
+          slack_token: ${{ secrets.SLACK_BOT_TOKEN }}
+
       - name: "Authenticate with Google Cloud"
         uses: "google-github-actions/auth@v1"
         with:
@@ -83,6 +84,7 @@ jobs:
         uses: ./.github/actions/slack-notify
         with:
           step: "failure"
+          blocked: ${{ steps.check_deployment_blocked.outputs.blocked }}
           component: "front-edge"
           image_tag: ${{ steps.short_sha.outputs.short_sha }}
           channel: ${{ secrets.SLACK_CHANNEL_ID }}

diff --git a/.github/workflows/deploy-front.yml b/.github/workflows/deploy-front.yml
@@ -34,6 +34,14 @@ jobs:
           channel: ${{ secrets.SLACK_CHANNEL_ID }}
           slack_token: ${{ secrets.SLACK_BOT_TOKEN }}
 
+      - name: Slack Check Deployment Blocked
+        id: check_deployment_blocked
+        uses: ./.github/actions/slack-check-deployment-blocked
+        with:
+          component: "front"
+          channel: ${{ secrets.SLACK_CHANNEL_ID }}
+          slack_token: ${{ secrets.SLACK_BOT_TOKEN }}
+
       - name: "Authenticate with Google Cloud"
         uses: "google-github-actions/auth@v1"
         with:
@@ -81,6 +89,7 @@ jobs:
         uses: ./.github/actions/slack-notify
         with:
           step: "failure"
+          blocked: ${{ steps.check_deployment_blocked.outputs.blocked }}
           component: "front"
           image_tag: ${{ steps.short_sha.outputs.short_sha }}
           channel: ${{ secrets.SLACK_CHANNEL_ID }}

diff --git a/.github/workflows/deploy-oauth.yml b/.github/workflows/deploy-oauth.yml
@@ -34,6 +34,14 @@ jobs:
           channel: ${{ secrets.SLACK_CHANNEL_ID }}
           slack_token: ${{ secrets.SLACK_BOT_TOKEN }}
 
+      - name: Slack Check Deployment Blocked
+        id: check_deployment_blocked
+        uses: ./.github/actions/slack-check-deployment-blocked
+        with:
+          component: "oauth"
+          channel: ${{ secrets.SLACK_CHANNEL_ID }}
+          slack_token: ${{ secrets.SLACK_BOT_TOKEN }}
+
       - name: "Authenticate with Google Cloud"
         uses: "google-github-actions/auth@v1"
         with:
@@ -81,6 +89,7 @@ jobs:
         uses: ./.github/actions/slack-notify
         with:
           step: "failure"
+          blocked: ${{ steps.check_deployment_blocked.outputs.blocked }}
           component: "oauth"
           image_tag: ${{ steps.short_sha.outputs.short_sha }}
           channel: ${{ secrets.SLACK_CHANNEL_ID }}

diff --git a/.github/workflows/deploy-prodbox.yml b/.github/workflows/deploy-prodbox.yml
@@ -35,6 +35,14 @@ jobs:
           channel: ${{ secrets.SLACK_CHANNEL_ID }}
           slack_token: ${{ secrets.SLACK_BOT_TOKEN }}
 
+      - name: Slack Check Deployment Blocked
+        id: check_deployment_blocked
+        uses: ./.github/actions/slack-check-deployment-blocked
+        with:
+          component: "prodbox"
+          channel: ${{ secrets.SLACK_CHANNEL_ID }}
+          slack_token: ${{ secrets.SLACK_BOT_TOKEN }}
+
       - name: "Authenticate with Google Cloud"
         uses: "google-github-actions/auth@v1"
         with:
@@ -86,6 +94,7 @@ jobs:
         uses: ./.github/actions/slack-notify
         with:
           step: "failure"
+          blocked: ${{ steps.check_deployment_blocked.outputs.blocked }}
           component: "prodbox"
           image_tag: ${{ steps.short_sha.outputs.short_sha }}
           channel: ${{ secrets.SLACK_CHANNEL_ID }}

diff --git a/.github/workflows/deploy-viz.yml b/.github/workflows/deploy-viz.yml
@@ -34,6 +34,14 @@ jobs:
           channel: ${{ secrets.SLACK_CHANNEL_ID }}
           slack_token: ${{ secrets.SLACK_BOT_TOKEN }}
 
+      - name: Slack Check Deployment Blocked
+        id: check_deployment_blocked
+        uses: ./.github/actions/slack-check-deployment-blocked
+        with:
+          component: "viz"
+          channel: ${{ secrets.SLACK_CHANNEL_ID }}
+          slack_token: ${{ secrets.SLACK_BOT_TOKEN }}
+
       - name: "Authenticate with Google Cloud"
         uses: "google-github-actions/auth@v1"
         with:
@@ -84,6 +92,7 @@ jobs:
         uses: ./.github/actions/slack-notify
         with:
           step: "failure"
+          blocked: ${{ steps.check_deployment_blocked.outputs.blocked }}
           component: "viz"
           image_tag: ${{ steps.short_sha.outputs.short_sha }}
           channel: ${{ secrets.SLACK_CHANNEL_ID }}