Skip to content

Commit

Permalink
ignore intercom collection not always being expandable (#10439)
Browse files Browse the repository at this point in the history
  • Loading branch information
aubin-tchoi authored Jan 31, 2025
1 parent 2bd09a6 commit 8d732bf
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions front/lib/api/content_nodes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,19 @@ export function computeNodesDiff({
if (key === "expandable" && value === true && coreValue === false) {
return false;
}
// Special case for expandable on Intercom collections: connectors does not allow expanding collections below the first level (there can be up to 3 levels of nesting in collections).
// This behavior has to be kept for /permissions, and is implemented in generic functions so cannot be changed for /content-nodes only and not /permissions.
// core will make them expandable if not empty no matter what.
// If we agree that this is the desired experience, we can ignore in the log.
if (
key === "expandable" &&
provider === "intercom" &&
coreNode.internalId.startsWith("intercom-collection") &&
value === false &&
coreValue === true
) {
return false;
}
// Special case for Slack's providerVisibility: we only check if providerVisibility === "private" so
// having a falsy value in core and "public" in connectors is the same.
if (
Expand Down

0 comments on commit 8d732bf

Please sign in to comment.