[sparkle] - fix(Citation): tooltip #10108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- TooltipContent is now wrapped in a TooltipPortal for better positioning and rendering in the DOM [sparkle] - feature: add tooltip to Citation component in stories - Implemented tooltip display for Citation component to show additional information on interaction
- Update package version in package-lock.json and package.json files - Ensure consistency across the package metadata for new release
- Change the title of the Citation component in stories to "Citation w/ tooltip" for better context in examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims at fixing the use of the
tooltipprops inCitation, which was incorrectly rendered because of a radix stacking context.Explanation: the
CitationGridcomponent uses a@container , which creates a new stacking context which confines the tooltip’s positioning. To free the tooltip from that confined stacking context, we need to render the tooltip content via aportal` so that it’s appended to the (or another top-level container), rather than living inside the CitationGrid.Risk
Low
Deploy Plan