[sparkle] - chore: ditch z-index classes #10212
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndex classes - Simplified import order rules by removing categorized comments and redundant groups - Enforced a new ESLint rule to prevent the use of z-index (s-z-) Tailwind classes in JSX
- Updated ESLint rules to split a long selector onto multiple lines for better readability - Removed z-index related tailwind classes (`s-z-*`) from various components to comply with new linting rules forbidding z-index usage - Added missing newline at end of .eslintrc.js file to follow convention
- Updated the package-lock.json and package.json to reflect the new version number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims at ditching all existing z-indexes on sparkle components and to add a linting rule to prevent from adding new ones.
As we are not doing anything extremely fancy for now there should be no need to use z-indexes. Also, adding z-indexes conflicts with indexes from Radix.
Risk
Quite important blast radius UX wise
Deploy Plan