Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a horizontal collapsible component for homepage/marketing needs #10258

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

albandum
Copy link
Contributor

Description

Creating a horizontal collapsible component to display use cases on the homepage like discussed with @ameliedrhub and @thib-martin

Screen.Recording.2025-01-28.at.10.12.08.mov

Tests

Risk

Deploy Plan

Deploy sparkle

@pinotalexandre
Copy link
Collaborator

Do we plan to use it again in the future ? If not I don't think it's useful to create a Sparkle component but just a local one

@albandum albandum requested a review from ameliedrhub January 28, 2025 09:18
@albandum
Copy link
Contributor Author

Do we plan to use it again in the future ? If not I don't think it's useful to create a Sparkle component but just a local one

It will likely be used in different places of the site when we publish more pages, is that what you mean?

@pinotalexandre
Copy link
Collaborator

Otherwise the component looks gooood. Waiting for Jules to approve the code :)

@pinotalexandre
Copy link
Collaborator

It will likely be used in different places of the site when we publish more pages, is that what you mean?

I meant in the product. We used to create local component for website, right ?

@Duncid
Copy link
Contributor

Duncid commented Jan 28, 2025

I'm a bit bearish on include pure website components in Sparkle.
We have a bunch of components that are used only in the website in the "home" folder of front, in ContentBlock.tsx, Caroussel.tsx", etc…

@JulesBelveze
Copy link
Contributor

I'm a bit bearish on include pure website components in Sparkle.

Same. I would refactor the existing Collapsible, as it is being used in front, and move it to radix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants