Add: location support when connecting bigquery #10453
Open
+698
−156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fraggle
force-pushed
the
sflory-add-region-in-credentials
branch
from
e2e0649 to
5f216ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add location selection (if needed) when connecting to BigQuery as it's not possible to do join between regions.
Store the location in the credentials to make it easy to retrieve from core.
Tests
Tested locally + added tests and updated tests.
Risk
Low as we are only touching the bigquery part.
Deploy Plan
Deploy
connectors,oauth,front