[front] Remove ToolGeneratedFileType in favor of blob resources #13508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract CSV/JSON generation logic from file creation functions - Update MCP servers to return blob resources instead of ToolGeneratedFile - Remove isToolGeneratedFile checks and special handling - Update UI components to work with simplified file data - Remove INTERNAL_MIME_TYPES.TOOL_OUTPUT.FILE constant 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
## Summary - Extracted CSV and JSON output generation from file upload logic - Updated all MCP servers to return blob resources instead of ToolGeneratedFile - Removed ToolGeneratedFileType, isToolGeneratedFile, and related schemas - Simplified UI components to work with simpler file resource structure - Removed unused INTERNAL_MIME_TYPES.TOOL_OUTPUT.FILE constant ## Risks - All MCP servers now return blob resources which are handled uniformly - UI components updated to work with simpler props structure - No breaking changes to external APIs ## Tests - TypeScript compilation passes - ESLint shows no errors - Code properly formatted ## Deploy Plan - Deploy front service 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
philipperolet
force-pushed
the
pr/177-remove-file-output
branch
from
f4f0132 to
2d8a9b1
Compare
|
philipperolet
force-pushed
the
pr/177-remove-file-output
branch
from
54088b4 to
c192b2a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
- Rename generateJSONOutput to generateJSONSnippet (only returns snippet) - Remove generateJSONFileAndSnippet function entirely - Remove EXTRACT_RESULT from INTERNAL_MIME_TYPES - Use ActionGeneratedFileType in MCPToolOutputDetails - Add uploadToConversationDataSource flag to handleBase64Upload - Use BlobCallToolResultBlock type in run_dust_app.ts - Move name field outside resource object - Add snippet field to blob resources - Move generateSectionFile to tables_query.ts module
philipperolet
commented
Jun 18, 2025
front/lib/actions/mcp.ts
Outdated
| isSupportedFileContentType(block.resource.mimeType) | ||
| ) { | ||
| if (isBlobResource(block)) { | ||
| const fileName = isResourceWithName(block) | ||
| ? block.name | ||
| : `generated-file-${Date.now()}.${extensionsForContentType(block.resource.mimeType as SupportedFileContentType)[0]}`; | ||
|
|
||
| // For extract_data server, we need to upload to conversation data source |
There was a problem hiding this comment.
remove that part. here we always want to upload to conversation ds
| @@ -4,18 +4,28 @@ import type { TextContent } from "@modelcontextprotocol/sdk/types.js"; | |||
| import type { ZodRawShape } from "zod"; | |||
| import { z } from "zod"; | |||
|
|
|||
| // Define the BlobCallToolResultBlock type | |||
There was a problem hiding this comment.
delete that and use the type with the same name from output_schemas.ts
| const content: { | ||
| type: "resource"; | ||
| name: string; | ||
| resource: { |
There was a problem hiding this comment.
use BlobCallToolResultBlock type
| contentType: plainTextFile.contentType, | ||
| snippet: plainTextFile.snippet, | ||
| text: `Generated text file: ${fileTitle}`, | ||
| uri: `data:text/plain;base64,${textContent.substring(0, 100)}...`, |
There was a problem hiding this comment.
here, as well as in 3 other places in this PR where this uri scheme was introduced, replace ${textcontent.substring... by "transient-content"
| resource: TablesQueryOutputResources; | ||
| } | ||
| | { | ||
| type: "resource"; |
There was a problem hiding this comment.
Use the resource field of BlobCallToolResultBlock here
- Remove uploadToConversationDataSource flag check - always upload to conversation DS - Replace data URI substring with 'transient-content' placeholder - Use BlobCallToolResultBlock type in tables_query server_v2 - Fix blob resource structure in server_v2 with name field outside resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ToolGeneratedFileType,isToolGeneratedFile, andToolGeneratedFileSchemain favor of standard blob resourcesINTERNAL_MIME_TYPES.TOOL_OUTPUT.FILEconstantRisks
Blast radius: MCP tool outputs and file generation across the platform
Risk: low
Tests
Local tests: mcp actions process, run dust app, table query
Deploy Plan