Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Front - Admin] Rewording user reinstating #2513

Merged
merged 1 commit into from
Nov 15, 2023
Merged

[Front - Admin] Rewording user reinstating #2513

merged 1 commit into from
Nov 15, 2023

Conversation

philipperolet
Copy link
Contributor

@philipperolet philipperolet commented Nov 13, 2023 •
edited
Loading

Following #2496

@gabhubert given your initial wording

$email is a revoked $member of the workspace. Reinstating as $member of the workspace them will also immediately reinstate their conversation history on Dust.

I made the following changes

  • is a revoked $member => I guess you want the last role of the member here, we don't have it => wrote "was revoked from the workspace
  • 'Reinstating as $member of the workspace them' => Reinstating them as member (we cannot do variable role as is so putting member directly; since the page is already saying "member list" I think it's clear
    image

gabhubert
gabhubert approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@gabhubert gabhubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

front/pages/w/[wId]/members/index.tsx
immediately.
<span className="font-semibold">{user.email + " "}</span> was revoked
from the workspace. Reinstating them as member will also immediately
reinstate their conversation history on Dust.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philipperolet philipperolet merged commit 7752676 into main Nov 15, 2023
1 check passed
@philipperolet philipperolet deleted the wording-revoke branch November 15, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabhubert gabhubert gabhubert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philipperolet @gabhubert