Code block cursor update #9692
Merged
Code block cursor update #9692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overmode
approved these changes
Jan 2, 2025
| @@ -101,7 +101,7 @@ export function ContentBlockWrapper({ | |||
| <div className="s-sticky s-top-0 s-z-50 s-w-full"> | |||
| <div | |||
| id="BlockActions" | |||
| className="s-flex s-w-full s-justify-end s-gap-1 s-p-2" | |||
| className="s-absolute s-right-2 s-top-2 s-z-50 s-flex s-gap-2" | |||
There was a problem hiding this comment.
Why do we need this (what problem does it solve) ?
There was a problem hiding this comment.
Viewed per IRL : cannot select first line if we don't use absolute
| @@ -124,7 +124,7 @@ export function ContentBlockWrapper({ | |||
| )} | |||
| </div> | |||
| </div> | |||
| <div className={cn("-s-mt-11 s-w-full", innerClassName)}>{children}</div> | |||
| <div className={cn("s-w-full", innerClassName)}>{children}</div> | |||
There was a problem hiding this comment.
Didn't we need this top margin ?
overmode
requested changes
Jan 2, 2025
pinotalexandre
added a commit
that referenced
this pull request
Jan 2, 2025
This reverts commit 15e0d22.
pinotalexandre
added a commit
that referenced
this pull request
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the cursor behavior :
Enregistrement.de.l.ecran.2025-01-02.a.11.54.40.mov
Risk
Deploy Plan
Merge PR