Bump keep-alive above default LBs #9749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@devloai review this PR |
![devloai[bot]](https://avatars.githubusercontent.com/in/886113?s=60&v=4){kind=small}
There was a problem hiding this comment.
The keep-alive timeout change looks reasonable but would benefit from better documentation and configurability. I've suggested adding code comments explaining the timeout value choice, documenting monitoring metrics, and making the value configurable via environment variable for easier production adjustments.
| @@ -3,7 +3,7 @@ | |||
| "dev:all": "concurrently --kill-others \"cd ../types/ && npm run start\" \"sleep 20 && cd ../sdks/js/ && npm run start\" \"sleep 22 && next dev\" \"sleep 22 && tsx ./start_worker.ts\"", | |||
| "dev": "next dev", | |||
| "build": "next build", | |||
| "start": "next start --keepAliveTimeout 6000", | |||
| "start": "next start --keepAliveTimeout 610000", | |||
There was a problem hiding this comment.
The keep-alive timeout is being increased by ~100x (from 6s to 610s). While this matches the strategy from vercel/next.js#35827, we should:
- Add a comment in the code explaining why this specific value (610000) was chosen and how it relates to ALB timeouts
- Document the metrics we'll be monitoring to detect any resource exhaustion issues (e.g. connection pool metrics, memory usage)
- Consider adding an environment variable for this value to make it easier to adjust in production if needed:
Suggested change
| "start": "next start --keepAliveTimeout 610000", | |
| "start": "next start --keepAliveTimeout ${NEXT_KEEP_ALIVE_TIMEOUT:-610000}", |
|
Giving it a spin after testing on front-edge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump keep-alive to very high value as inspired by https://github.com/vercel/next.js/pull/35827/files + above known ALB values.
Risk
Will deploy on front-edge first to test and give it a try. Many potential risks of resource exhaustion. Will monitor and revert accordingly.
Deploy Plan
frontand monitor