Remove legacy "autoReadPattern" slack. #9761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Automatic code review is enabled for this repository. I will perform a review of this PR. |
flvndvd
added
the
migration-ack
![devloai[bot]](https://avatars.githubusercontent.com/in/886113?s=60&v=4){kind=small}
There was a problem hiding this comment.
The changes look good and systematically remove the deprecated autoReadChannelPattern functionality across all layers. I've suggested a minor improvement to document the migration file better for future reference. Otherwise, the removal is clean with no remaining references to the old field.
| @@ -0,0 +1,2 @@ | |||
| -- Migration created on Jan 06, 2025 | |||
| ALTER TABLE slack_configurations DROP COLUMN "autoReadChannelPattern"; | |||
There was a problem hiding this comment.
Consider adding a comment explaining that this column was deprecated in favor of autoReadChannelPatterns for future reference. Something like:
Suggested change
| ALTER TABLE slack_configurations DROP COLUMN "autoReadChannelPattern"; | |
| -- Migration created on Jan 06, 2025 | |
| -- Drop legacy autoReadChannelPattern column which was deprecated in favor of autoReadChannelPatterns | |
| ALTER TABLE slack_configurations DROP COLUMN "autoReadChannelPattern"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up of the recent work around adding support for spaces in Slack auto read patterns. This PR removes the deprecated code.
Risk
Deploy Plan