fix(Zendesk) - fix db queries #9764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Automatic code review is enabled for this repository. I will perform a review of this PR. |
![devloai[bot]](https://avatars.githubusercontent.com/in/886113?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've reviewed the changes for the Zendesk DB query fixes. The changes look solid overall, properly implementing brandId-based filtering and adding appropriate indexes. I've noted a few items to address: a potential bug in the delete method parameter, inconsistent index naming patterns, and a suggestion for additional error handling. Please review these comments to ensure robust implementation.
aubin-tchoi
force-pushed
the
zendesk-fix-db-queries
branch
from
d20ba34 to
1f37fb2
Compare
aubin-tchoi
added
the
migration-ack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
brandId.Risk
Deploy Plan
migration_44.sql