Conversation: Add column lastUserMessageAt to then sort convo by last used #9788
Conversation
|
Automatic code review is enabled for this repository. I will perform a review of this PR. |
![devloai[bot]](https://avatars.githubusercontent.com/in/886113?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've reviewed the changes adding the lastUserMessageAt column. The implementation is solid and takes a safe approach with the nullable column. I've suggested two improvements: adding an index to support efficient sorting and adding documentation for better maintainability. The PR is well-structured and ready to merge after addressing these suggestions.
| @@ -0,0 +1,2 @@ | |||
| -- Migration created on Jan 07, 2025 | |||
| ALTER TABLE "public"."conversations" ADD COLUMN "lastUserMessageAt" TIMESTAMP WITH TIME ZONE; | |||
There was a problem hiding this comment.
Since this column will be used for sorting conversations, it would be good to add an index on it. Consider adding:
| ALTER TABLE "public"."conversations" ADD COLUMN "lastUserMessageAt" TIMESTAMP WITH TIME ZONE; | |
| ALTER TABLE "public"."conversations" ADD COLUMN "lastUserMessageAt" TIMESTAMP WITH TIME ZONE; | |
| CREATE INDEX CONCURRENTLY "conversations_last_user_message_at_idx" ON "public"."conversations" ("lastUserMessageAt"); |
The CONCURRENTLY option ensures the index is built without blocking writes to the table.
PopDaph
added
the
migration-ack
|
Wait actually I wonder if there's not a smarter way to do that using the ConversationParticipants table |
Description
Context: https://github.com/dust-tt/tasks/issues/1882
This is the first PR to create the new nullable column.
Once deployed I'll add the code to fill this one + use it to sort conversations.
Risk
Column is nullable so should be non-blocking, even it the table is large.
Deploy Plan
Merge
Run migration
Deploy front.