Skip to content

Commit

Permalink
chore(cb2-12276): upgrade to node version 20
Browse files Browse the repository at this point in the history
  • Loading branch information
Ruairidh-BJSS committed May 22, 2024
1 parent 29ddd88 commit dc30993
Show file tree
Hide file tree
Showing 7 changed files with 72 additions and 106 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pr-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [18.x]
node-version: [20.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
18.*
20.*

2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ A typescript lambda function that takes an S3 bucket event, processes the file t

## Requirements

- node v18
- node v20
- npm v9
- aws cli v2

Expand Down
166 changes: 66 additions & 100 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "Gets, packages, and sends the EVL data file.",
"main": "index.js",
"engines": {
"node": "^18.*"
"node": "^20.*"
},
"scripts": {
"start": "sls offline start",
Expand Down
2 changes: 1 addition & 1 deletion serverless.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ plugins:
provider:
region: eu-west-1
name: aws
runtime: nodejs18.x
runtime: nodejs20.x

functions:
evlFilePush:
Expand Down
2 changes: 1 addition & 1 deletion tests/filePush/filePush.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ describe('test the create config function', () => {
expect.assertions(1);
delete process.env.EVL_SFTP_CONFIG;
await expect(createConfig('evl')).rejects.toThrow(
new Error('Unexpected token u in JSON at position 0'),
new Error('"undefined" is not valid JSON'),
);
});
});

0 comments on commit dc30993

Please sign in to comment.