feat(CB2-12695): update eslint rules

dvsa · Jul 10, 2024 · e727ca6 · e727ca6
1 parent 7cc8af2
commit e727ca6
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 3 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -1,3 +1,23 @@
 {
-  "extends": ["@dvsa/eslint-config-ts", "prettier"]
+  "extends": ["@dvsa/eslint-config-ts", "prettier"],
+  "settings": {
+    "import/resolver": {
+      "typescript": {
+        "alwaysTryTypes": true
+      }
+    }
+  },
+  "rules": {
+    "import/no-extraneous-dependencies": [
+      "error",
+      {
+        "devDependencies": true
+      }
+    ],
+    "max-len":["error", {
+      "code": 150,
+      "ignoreComments": true
+    }],
+    "@typescript-eslint/no-unsafe-enum-comparison": "off"
+  }
 }
diff --git a/src/utils/ExtractTestResults.ts b/src/utils/ExtractTestResults.ts
@@ -37,15 +37,15 @@ export const extractMCTestResults = (record: DynamoDBRecord): MCRequest[] => {
     )
     .filter(
       (testType) =>
-        (testType.testResult as TestResults) === TestResults.PASS || (testType.testResult as TestResults) === TestResults.PRS,
+        testType.testResult === TestResults.PASS || testType.testResult === TestResults.PRS,
     )
     .filter(
       () =>
         testResultUnmarshall.vehicleType === 'hgv' ||
         testResultUnmarshall.vehicleType === 'psv' ||
         testResultUnmarshall.vehicleType === 'trl',
     )
-    .filter(() => (testResultUnmarshall.testStatus as TestStatus) === TestStatus.SUBMITTED)
+    .filter(() => testResultUnmarshall.testStatus === TestStatus.SUBMITTED)
     .map((testType : TestTypeSchema ) : MCRequest => ({
       vehicleIdentifier:
         testResultUnmarshall.vehicleType === 'trl'