feat(cb2-14764): patch for removing nullable

dvsa · Nov 19, 2024 · 2421f2b · 2421f2b
1 parent d9c59de
commit 2421f2b
Show file tree

Hide file tree

Showing 9 changed files with 12 additions and 21 deletions.
diff --git a/json-definitions/v1/recalls/index.json b/json-definitions/v1/recalls/index.json
@@ -3,10 +3,7 @@
   "type": "object",
   "properties": {
     "hasRecall": {
-      "type": [
-        "boolean",
-        "null"
-      ]
+      "type": "boolean"
     },
     "manufacturer": {
       "type": [

diff --git a/json-definitions/v1/test-result/index.json b/json-definitions/v1/test-result/index.json
@@ -283,9 +283,6 @@
       "anyOf": [
         {
           "$ref": "../recalls/index.json"
-        },
-        {
-          "type": "null"
         }
       ]
     }

diff --git a/json-schemas/v1/recalls/index.json b/json-schemas/v1/recalls/index.json
@@ -3,10 +3,7 @@
 	"type": "object",
 	"properties": {
 		"hasRecall": {
-			"type": [
-				"boolean",
-				"null"
-			]
+			"type": "boolean"
 		},
 		"manufacturer": {
 			"type": [

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@dvsa/cvs-type-definitions",
-  "version": "7.7.0",
+  "version": "7.7.1",
   "description": "type definitions for cvs vta and vtm applications",
   "main": "index.js",
   "repository": {

diff --git a/types/v1/recalls/index.d.ts b/types/v1/recalls/index.d.ts
@@ -6,6 +6,6 @@
  */
 
 export interface RecallsSchema {
-  hasRecall: boolean | null;
+  hasRecall: boolean;
   manufacturer: string | null;
 }
diff --git a/types/v1/test-result/index.d.ts b/types/v1/test-result/index.d.ts
@@ -61,7 +61,7 @@ export interface TestResultSchema {
   testHistory?: TestResultSchema[];
   testVersion?: string;
   deletionFlag?: boolean;
-  recalls?: RecallsSchema | null;
+  recalls?: RecallsSchema;
 }
 export interface VehicleClassSchema {
   code: string;
@@ -205,7 +205,7 @@ export interface BodyTypeSchema {
   description?: string | null;
 }
 export interface RecallsSchema {
-  hasRecall: boolean | null;
+  hasRecall: boolean;
   manufacturer: string | null;
 }
 

diff --git a/types/v1/test/index.d.ts b/types/v1/test/index.d.ts
@@ -282,7 +282,7 @@ export interface TestResultSchema {
   testHistory?: TestResultSchema[];
   testVersion?: string;
   deletionFlag?: boolean;
-  recalls?: RecallsSchema | null;
+  recalls?: RecallsSchema;
 }
 export interface TestTypeSchema {
   testTypeName: string | null;
@@ -422,7 +422,7 @@ export interface BodyTypeSchema {
   description?: string | null;
 }
 export interface RecallsSchema {
-  hasRecall: boolean | null;
+  hasRecall: boolean;
   manufacturer: string | null;
 }
 

diff --git a/types/v1/vehicle/index.d.ts b/types/v1/vehicle/index.d.ts
@@ -274,7 +274,7 @@ export interface TestResultSchema {
   testHistory?: TestResultSchema[];
   testVersion?: string;
   deletionFlag?: boolean;
-  recalls?: RecallsSchema | null;
+  recalls?: RecallsSchema;
 }
 export interface TestTypeSchema {
   testTypeName: string | null;
@@ -414,7 +414,7 @@ export interface BodyTypeSchema {
   description?: string | null;
 }
 export interface RecallsSchema {
-  hasRecall: boolean | null;
+  hasRecall: boolean;
   manufacturer: string | null;
 }
 

diff --git a/types/v1/visit/index.d.ts b/types/v1/visit/index.d.ts
@@ -295,7 +295,7 @@ export interface TestResultSchema {
   testHistory?: TestResultSchema[];
   testVersion?: string;
   deletionFlag?: boolean;
-  recalls?: RecallsSchema | null;
+  recalls?: RecallsSchema;
 }
 export interface TestTypeSchema {
   testTypeName: string | null;
@@ -435,7 +435,7 @@ export interface BodyTypeSchema {
   description?: string | null;
 }
 export interface RecallsSchema {
-  hasRecall: boolean | null;
+  hasRecall: boolean;
   manufacturer: string | null;
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -283,9 +283,6 @@ @@
           "anyOf": [
             {
               "$ref": "../recalls/index.json"
-            },
-            {
-              "type": "null"
             }
           ]
         }
@@ Expand Down @@