Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch(CB2-9183): update vehicle class code and description #131

Merged
merged 5 commits into from
Oct 26, 2023

Conversation

shivangidas
Copy link
Contributor

@shivangidas shivangidas commented Oct 26, 2023

Update vehicle class options

This includes changes for hgv, trailer, and psv (not light vehicles)

CB2-9183

Changelog

  • vehicle class code and description updated for hgv, trl, psv

@shivangidas shivangidas changed the title patch(cb2-9183): update vehicle class code and description patch(CB2-9183): update vehicle class code and description Oct 26, 2023
Copy link

@TheWorldWideWebb TheWorldWideWebb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a major change since it changes the definition of a well defined type that causes breaking changes, same for yesterdays enum changes 😄

@shivangidas
Copy link
Contributor Author

This is a major change since it changes the definition of a well defined type that causes breaking changes, same for yesterdays enum changes 😄

That's a good point. I think the first enum PR did a minor version change, thinking of continuing with that for all the enum tickets

@shivangidas shivangidas merged commit 1e05fc7 into develop Oct 26, 2023
@shivangidas
Copy link
Contributor Author

This is a major change since it changes the definition of a well defined type that causes breaking changes, same for yesterdays enum changes 😄

That's a good point. I think the first enum PR did a minor version change, thinking of continuing with that for all the enum tickets

My bad, it was a different IVA related change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants