-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: BL-17333 - Dockerfile and resources for Apache PHP 8.2, base image only #42
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
@barkerl Cannot add you too review list, can you please approve this PR. |
- php/8.3/fpm-nginx | ||
- php/8.0/cli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks to be the php8.0 VOL cli image if i had to guess. It looks like this will have been a timing/rebasing issue after those were removed from the VOL side.
I think these can probably safely be removed, the CI workflows weren't failing prior to merge.
Description
Add the Apache PHP8.3 Alpine image to repo. This should not be merged until the ECR Repos for these images have been created (pending access).
Related issue: https://dvsa.atlassian.net/browse/BL-17333
Before submitting (or marking as "ready for review")
@barkerl to add review also