Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: BL-17333 - Dockerfile and resources for Apache PHP 8.2, base image only #42

Merged
merged 20 commits into from
Aug 8, 2024

Conversation

CWRahien
Copy link
Contributor

@CWRahien CWRahien commented Jul 17, 2024

Description

Add the Apache PHP8.3 Alpine image to repo. This should not be merged until the ECR Repos for these images have been created (pending access).

Related issue: https://dvsa.atlassian.net/browse/BL-17333

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@barkerl to add review also

@CWRahien CWRahien changed the title Dockerfile and resources for apache php8.3 feat: BL-17333 - Dockerfile and resources for apache php8.3 Jul 17, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

.github/workflows/cd.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@CWRahien CWRahien changed the title feat: BL-17333 - Dockerfile and resources for apache php8.3 feat: BL-17333 - Dockerfile and resources for Apache PHP 8.2, base image only Aug 7, 2024
@jcrozier
Copy link
Contributor

jcrozier commented Aug 8, 2024

@barkerl Cannot add you too review list, can you please approve this PR.

@barkerl barkerl merged commit 8545e46 into dvsa:main Aug 8, 2024
4 checks passed
- php/8.3/fpm-nginx
- php/8.0/cli
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come the PHP 8.0 lines were added in this PR without a respective Dockerfile? Can we sort this please - it has broken the CI.

@CWRahien @jcrozier @barkerl

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks to be the php8.0 VOL cli image if i had to guess. It looks like this will have been a timing/rebasing issue after those were removed from the VOL side.

I think these can probably safely be removed, the CI workflows weren't failing prior to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants