feat: add logstash image #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barkerl
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Three of the existing issues only exist for windows hosted logstache installations (which this isn't).
The two other finding are mediums and break the existing functionality when tested locally. On that basis happy to approve. This is a significant improvement to where we are on services atm.
Wi11Shell
force-pushed
the
feat/add_logstash_image
branch
from
0a70cc6 to
9099707
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue: https://dvsa.atlassian.net/browse/VOL-5941
Before submitting (or marking as "ready for review")