Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add devcontainers #34

Merged
merged 1 commit into from
Mar 19, 2024
Merged

feat: add devcontainers #34

merged 1 commit into from
Mar 19, 2024

Conversation

JoshuaLicense
Copy link
Contributor

@JoshuaLicense JoshuaLicense commented Mar 13, 2024

Description

Adds 3 devcontainers; developer, devops, & complete - each focussed on a different role. Split to create more scoped containers.

devops container:

  • Terraform
  • Terraform Docs
  • TFLint
  • Node (20) - for githooks & linting.

developer container:

  • PHP 8.3
  • Node (20) - for githooks & linting.
  • Docker - will be utilised to spin up the VOL application in the future.

I know it's not the correct version, but I don't expect a developer in this repository yet. When this repository becomes a mono-repository the PHP version will be near to PHP 8.3.

complete container:

  • All the above.

Related issue: https://dvsa.atlassian.net/browse/VOL-4866

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@JoshuaLicense JoshuaLicense self-assigned this Mar 13, 2024
@JoshuaLicense JoshuaLicense marked this pull request as ready for review March 14, 2024 10:41
@JoshuaLicense JoshuaLicense merged commit fb3e8f4 into main Mar 19, 2024
10 checks passed
@JoshuaLicense JoshuaLicense deleted the add-dev-containers branch March 19, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant