Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update DataGovUkExport.php to upload to S3 bucket #357

Merged
merged 1 commit into from
Oct 3, 2024
Merged

feat: update DataGovUkExport.php to upload to S3 bucket #357

merged 1 commit into from
Oct 3, 2024

Conversation

fibble
Copy link
Contributor

@fibble fibble commented Sep 27, 2024

Description

Update DataGov export to upload to S3 if given an s3:// URI

Related issue: VOL-5819

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@fibble fibble changed the title feat: Update DataGovUkExport.php to upload to S3 bucket. WIP! feat: update DataGovUkExport.php to upload to S3 bucket Oct 3, 2024
@fibble fibble force-pushed the modify-batch-job-datagovuk-upload-to-s3-vol-5819 branch from 7a3a4ff to ad1a31e Compare October 3, 2024 08:15
@fibble fibble marked this pull request as ready for review October 3, 2024 08:17
@fibble fibble requested review from ilindsay and a team as code owners October 3, 2024 08:17
jerotire
jerotire previously approved these changes Oct 3, 2024
View reviewed changes
@fibble fibble force-pushed the modify-batch-job-datagovuk-upload-to-s3-vol-5819 branch from 523850e to f10a9e1 Compare October 3, 2024 09:54
@fibble fibble force-pushed the modify-batch-job-datagovuk-upload-to-s3-vol-5819 branch from f10a9e1 to 023790c Compare October 3, 2024 10:01
@ilindsay ilindsay merged commit 3414573 into main Oct 3, 2024
19 checks passed
@ilindsay ilindsay deleted the modify-batch-job-datagovuk-upload-to-s3-vol-5819 branch October 3, 2024 11:21
@github-actions github-actions bot mentioned this pull request Oct 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielg2020 gabrielg2020 gabrielg2020 approved these changes

@ilindsay ilindsay ilindsay approved these changes

@jerotire jerotire jerotire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fibble @jerotire @ilindsay @gabrielg2020