Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/split utils into submodules #628

Conversation

randomir
Copy link
Member

Related to #437.

Enables import time optimization.

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 91.22137% with 46 lines in your changes missing coverage. Please review.

Project coverage is 88.41%. Comparing base (7bc2a1d) to head (f577411).
Report is 158 commits behind head on master.

Files with missing lines Patch % Lines
dwave/cloud/solver.py 31.57% 13 Missing ⚠️
dwave/cloud/utils/cli.py 78.04% 9 Missing ⚠️
dwave/cloud/utils/logging.py 90.32% 9 Missing ⚠️
dwave/cloud/utils/dist.py 63.63% 8 Missing ⚠️
dwave/cloud/cli.py 77.77% 2 Missing ⚠️
dwave/cloud/utils/decorators.py 98.78% 2 Missing ⚠️
dwave/cloud/utils/coders.py 96.55% 1 Missing ⚠️
dwave/cloud/utils/http.py 98.03% 1 Missing ⚠️
dwave/cloud/utils/qubo.py 97.43% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #628      +/-   ##
==========================================
+ Coverage   88.22%   88.41%   +0.18%     
==========================================
  Files          33       42       +9     
  Lines        4527     4558      +31     
==========================================
+ Hits         3994     4030      +36     
+ Misses        533      528       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@randomir randomir force-pushed the refactor/split-utils-into-submodules/related-to-437 branch from 426c0a6 to cfec653 Compare June 13, 2024 20:55
@randomir randomir requested a review from arcondello June 13, 2024 20:56
@randomir randomir marked this pull request as ready for review June 13, 2024 20:56
Copy link
Member

@arcondello arcondello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't look too closely at the functions because I believe most of them have just been moved. Structure seems like a nice improvement.

@randomir randomir force-pushed the refactor/split-utils-into-submodules/related-to-437 branch from cfec653 to f577411 Compare June 13, 2024 21:11
@randomir randomir merged commit dbdb9d3 into dwavesystems:master Jun 13, 2024
31 checks passed
@randomir randomir deleted the refactor/split-utils-into-submodules/related-to-437 branch June 13, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants