-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define BQP with links in BQM description #75
base: master
Are you sure you want to change the base?
Conversation
@@ -47,6 +47,13 @@ The :class:`.BinaryQuadraticModel` class can contain both these models and its m | |||
convenient utilities for working with, and interworking between, the two representations | |||
of a problem. | |||
|
|||
Binary quadratic models are sometimes referred to as (unconstrained) binary | |||
`quadratic programs`_. We use BQM to avoid confusion with the | |||
`bounded error quantum polynomial time`_ (BQP) complexity class. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't add the "We use BQM to avoid confusion with..." here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What language would you use instead? I think it's important to highlight that this is not BQP - it's come up before even though they are used in very different contexts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the first sentence, that states that BQMs can be thought of as binary quadratic programs, coming after a description of what BQMs are, does the work. I don't see how anyone at this point would confuse BQM and BQP.
Someone somewhere else might be confused but not someone whose just read the text above, so at this point introducing BQP would make sense if you wanted to talk about BQP in relation to QA, but not to dismiss a confusion that is unlikely relevant here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about
Binary quadratic models are sometimes referred to as (unconstrained) binary `quadratic programs`_. Not to be confused with BQP_, a quantum complexity class.
Another approach would be a wikipedia style
For the quantum complexity class, see BQP_
and put it at the top. Example found using wikipedia's "random article" feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that would be good: For the quantum complexity class, see bounded-error quantum polynomial time (BQP) <https://en.wikipedia.org/wiki/BQP>
_.
If you think many users coming to BQM have this confusion, it's worth putting at the top. My guess is that those are a small minority versus beginners looking for a definition of BQM, so would be better at the end.
No description provided.