Fix: Prevent implicit float-to-int conversion in PHP 8.1 when indexin… #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g arrays in qrencode.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves a compatibility issue with PHP 8.1 in the file. Specifically, it prevents implicit float-to-int conversions when indexing arrays, which previously triggered hundreds of warnings during QR code generation.
The fix ensures that all array indices are explicitly cast or calculated as integers using or rounding, preserving the integrity of the QR code output.
The solution has been validated by:
• Running the code in a PHP 8.1 environment with no warnings or notices.
• Confirming that the generated QR codes are valid and scannable using standard QR readers.
Backward compatibility with earlier PHP versions is maintained, as the changes rely only on standard integer operations and do not introduce any breaking syntax or dependencies.