Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What are we offering? #192

Open
jrans opened this issue Sep 21, 2016 · 3 comments
Open

What are we offering? #192

jrans opened this issue Sep 21, 2016 · 3 comments

Comments

@jrans
Copy link
Member

jrans commented Sep 21, 2016

So far this REPO and read me is geared up to offer a linter that offers the good parts.

However, we also want to help ensure a consistent style for our developers' code. This goes beyond the good parts and therefore may not be desirable.

We should therefore split off "Stylistic" Linting Rules and enable options to have just good parts or good parts with dwyl style.

@nelsonic @iteles Thoughts?

@nelsonic
Copy link
Member

nelsonic commented Sep 21, 2016

@jrans while I agree that by adding stylistic elements/rules we are going beyond the strict recommendations of "JavaScript The Good Parts" ... we need to decide if that means we cannot "brand" our style as "GoodParts" ... is it enough to add a clarification in the Readme? _or_ do we need to re-name it?

e.g: JavaScript Style Guide (i.e. "House Rules")

or: JavaScript Style Guide

or JavaScript Style Guide

@jrans jrans mentioned this issue Sep 23, 2016
@eliasmalik
Copy link
Contributor

@nelsonic @SimonLab @Shouston3 please see #229 (comment) for the current name of the package and suggest alternatives if you wish.

@nelsonic
Copy link
Member

@jrans / @eliasCodes, the choice of Repo & NPM Package name is mean to make it fairly generic.
We need to a bunch of tidying up in the Readme to make it clear that this is JavaScript The Good Parts _and_ some Style-specific rules which we think are practical/sensible for our needs but weren't specified in the Good Parts (book or DC's talks).

We are building this for us first and if anyone else likes it they are welcome to use it.

If only dwyl projects end up using the style I'm 100% fine with that. 👍

@nelsonic nelsonic removed their assignment Feb 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants