Sharing #229
Sharing #229
Conversation
| "peerDependencies": { | ||
| "eslint": ">=3.5.0" | ||
| }, | ||
| "contributors": [ |
There was a problem hiding this comment.
gitter handle may be better! hehe
There was a problem hiding this comment.
changed to github handles and added @nelsonic
| @@ -1,12 +1,23 @@ | |||
| { | |||
| "name": "goodparts", | |||
| "name": "eslint-config-dwyl", | |||
There was a problem hiding this comment.
do we want to double check name with everyone? brings us back to #192 , the name of this module will be a good indication
There was a problem hiding this comment.
dwyl-goodparts eslint-goodparts eslint-dwyl all possible contenders too
| "extends": "dwyl" | ||
| } | ||
| ``` | ||
| Alternatively, you can also add this to the `"eslintConfig"` field in your `package.json`. |
There was a problem hiding this comment.
I'm lazy can you provide the exact linting command
There was a problem hiding this comment.
Made this explicit in 1e7ab4c
|
Before merging name of package needs to be decided but then ready, @Shouston3 @SimonLab @nelsonic thoughts? |
| Then you can add the following script to your `package.json`: | ||
| ``` | ||
| { | ||
| "lint": "node_modules/.bin/goodparts path/to/files/for/linting" |
There was a problem hiding this comment.
@eliasCodes could we specify a bin script in package.json ?
see: https://docs.npmjs.com/files/package.json#bin
There was a problem hiding this comment.
I have 82796e6
Or do you mean changing the script to "lint": "goodparts path/to/files/for/linting"
There was a problem hiding this comment.
Looks like a good start. thanks!
|
thanks @eliasCodes !! 👍 |
|
Did we go with |
Changes necessary to make this config easily shareable.
Tested this locally using
npm linkand adding an.eslintrc.jsonfile to a new project with the following contents:{ "extends": "dwyl" }Updated README with instructions.
All thats then left to be done is to publish to
npm. Current version is0.0.1which will be the initial version unless someone has a problem with it.