Human-friendly workspace branch naming #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add BranchNameGenerator (Domain) with format: <YYYY-MM-DD H:i:s>-usermailATdomainDOTtld-SHORTWORKSPACEID - Require userEmail in dispatchSetupIfNeeded and SetupWorkspaceMessage - Thread userEmail through setup: controller (accountInfo->email), prefab subscriber (accountCoreId -> account email) - Unit tests for BranchNameGenerator (format, sanitization, short ID) - Update docs (project-workspace-conversation-workflow-high-level.md) - Wire BranchNameGeneratorInterface in config/services.yaml Fixes #67
github-project-automation
bot
moved this to Backlog
in SiteBuilder · Product Development Kanban
- Branch name timestamp: Y-m-d H:i:s → Y-m-d_H-i-s (no space/colons) - Add .cursor/rules/08-symfony-services.mdc: do not add explicit interface bindings when autowiring resolves single implementation - Remove redundant BranchNameGeneratorInterface and WorkspaceStatusGuardInterface from config/services.yaml - Update docs and tests for new format Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements human-friendly workspace branch naming as specified in #67.
Format:
<YYYY-MM-DD H:i:s>-usermailATdomainDOTtld-SHORTWORKSPACEIDExample:
2025-02-05 14:30:22-manuelATkiesslingDOTnet-a1b2c3d4Changes
@→AT,.→DOT), and short workspace ID (first 8 chars).dispatchSetupIfNeeded(projectId, userEmail)on facade and interface.SetupWorkspaceMessage(workspaceId, userEmail).WorkspaceSetupService::setup(workspace, userEmail).$accountInfo->email; prefab subscriber resolves$event->accountCoreIdvia AccountFacade and passes account email (throws if account not found).config/services.yaml.BranchNameGeneratorTest(format, email sanitization, short ID).project-workspace-conversation-workflow-high-level.mdupdated to new format.Checklist
mise run qualityandmise run testsandmise run tests:frontendpass.Fixes #67