feat: Always use the newest validation scratch org during Validate

[alanjaouen]

Summary generated by Reviewpad on 08 Nov 23 22:07 UTC

This pull request includes two patches.

The first patch updates the ORDER BY filter in the ScratchOrgInfoFetcher.ts file from "ORDER BY CreatedDate ASC" to "ORDER BY CreatedDate DESC".

The second patch adds spaces to the queries in the ScratchOrgInfoFetcher.ts file, improving readability.

fixes #1228

Checklist

All items have to be completed before a PR is merged

• Adhere to Contribution Guidelines
• Updates to Decision Records considered?
• Updates to documentation at DX@Scale Guide considered?
• Tested changes?
• Unit Tests new and existing passing locally?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dca75e6) 46.86% compared to head (87e253d) 46.86%.

❗ Current head 87e253d differs from pull request most recent head 0d67a71. Consider uploading reports for the commit 0d67a71 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1428   +/-   ##
=======================================
  Coverage   46.86%   46.86%           
=======================================
  Files          70       70           
  Lines        2665     2665           
  Branches      302      313   +11     
=======================================
  Hits         1249     1249           
+ Misses       1414     1386   -28     
- Partials        2       30   +28     

see 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[NathanielNizard]

Would help us greatly at Aviv Group. One Team.

[azlam-abdulsalam]

@NathanielNizard definitely, just need to test it, otherwise I am all good

@alanjaouen have you tested it?

[alanjaouen]

@azlam-abdulsalam tested loccaly, I don't know how to / if I can unit test this