This repository was archived by the owner on Mar 18, 2024. It is now read-only.
feat(install): Specify testLevel for a not optimized source package validating#1434
Merged
azlam-abdulsalam merged 3 commits intodxatscale:mainfrom Nov 13, 2023
nabondance:issue1417
Merged
feat(install): Specify testLevel for a not optimized source package validating#1434azlam-abdulsalam merged 3 commits intodxatscale:mainfrom nabondance:issue1417
azlam-abdulsalam merged 3 commits intodxatscale:mainfrom
nabondance:issue1417
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1434 +/- ##
=======================================
Coverage 46.86% 46.86%
=======================================
Files 70 70
Lines 2665 2665
Branches 302 302
=======================================
Hits 1249 1249
Misses 1414 1414
Partials 2 2 ☔ View full report in Codecov by Sentry. |
azlam-abdulsalam
approved these changes
Nov 8, 2023
Contributor
azlam-abdulsalam
left a comment
There was a problem hiding this comment.
@nabondance I think this is all good, its the cheapest one. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1417 using solution number 3
It was the solution with the smallest amount of code needed
Tested locally and working for the use case
Fell free to adapt and modify if needed
reviewpad:summary
Checklist
All items have to be completed before a PR is merged