Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Accordion ACF warning for the_sub_field #47

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Fix Accordion ACF warning for the_sub_field #47

merged 2 commits into from
Sep 9, 2024

Conversation

serena-piccioni
Copy link
Contributor

Description

This PR fixes this warning from ACF:

ACF PRO — ACF now automatically escapes unsafe HTML when rendered by the_field or the ACF shortcode. We've detected the output of some of your fields has been modified by this change, but this may not be a breaking change. Learn more.

accordion_section_content (Section content) - rendered via the_sub_field
This data is logged as we detect values that have been changed during output. Clear log and dismiss after escaping the values in your code. The notice will reappear if we detect changed values again.

How to test

  • Checkout this branch
  • Add the plugin to any local installation and activate it
  • Check that there are no warnings in the admin from ACF Pro

snim2
snim2 reviewed Sep 9, 2024
View reviewed changes
.php-cs-fixer.cache Outdated
{"php":"7.4.33","version":"3.64.0:v3.64.0#58dd9c931c785a79739310aef5178928305ffa67","indent":"\t","lineEnding":"\n","rules":{"binary_operator_spaces":{"default":"at_least_single_space"},"blank_line_after_opening_tag":true,"blank_line_between_import_groups":true,"blank_lines_before_namespace":true,"braces_position":{"allow_single_line_empty_anonymous_classes":true},"class_definition":{"inline_constructor_arguments":false,"space_before_parenthesis":true},"compact_nullable_type_declaration":true,"declare_equal_normalize":true,"lowercase_cast":true,"lowercase_static_reference":true,"new_with_parentheses":true,"no_blank_lines_after_class_opening":true,"no_extra_blank_lines":{"tokens":["use"]},"no_leading_import_slash":true,"no_whitespace_in_blank_line":true,"ordered_class_elements":{"order":["use_trait"]},"ordered_imports":{"imports_order":["class","function","const"],"sort_algorithm":"none"},"return_type_declaration":true,"short_scalar_cast":true,"single_import_per_statement":{"group_to_single_imports":false},"single_space_around_construct":{"constructs_followed_by_a_single_space":["abstract","as","case","catch","class","const_import","do","else","elseif","final","finally","for","foreach","function","function_import","if","insteadof","interface","namespace","new","private","protected","public","static","switch","trait","try","use","use_lambda","while"],"constructs_preceded_by_a_single_space":["as","else","elseif","use_lambda"]},"single_trait_insert_per_statement":true,"ternary_operator_spaces":true,"unary_operator_spaces":{"only_dec_inc":true},"visibility_required":true,"blank_line_after_namespace":true,"constant_case":true,"control_structure_braces":true,"control_structure_continuation_position":true,"elseif":true,"function_declaration":true,"indentation_type":true,"line_ending":true,"lowercase_keywords":true,"method_argument_space":{"attribute_placement":"ignore","on_multiline":"ensure_fully_multiline"},"no_break_comment":true,"no_closing_tag":true,"no_multiple_statements_per_line":true,"no_space_around_double_colon":true,"no_spaces_after_function_name":true,"no_trailing_whitespace":true,"no_trailing_whitespace_in_comment":true,"single_blank_line_at_eof":true,"single_class_element_per_statement":{"elements":["property"]},"single_line_after_imports":true,"spaces_inside_parentheses":true,"statement_indentation":true,"switch_case_semicolon_to_colon":true,"switch_case_space":true,"encoding":true,"full_opening_tag":true,"array_syntax":{"syntax":"short"}},"hashes":{"app\/Blocks\/InsetText.php":"ca6db9fb90e6dc38036fd329b08b4feb","app\/Blocks\/WarningText.php":"4eedb41fdb8d9e32ed8f3a29954544e1","app\/Blocks\/Details.php":"229dc7f4122755f35c0eaa2ebc0870b2","app\/Blocks\/Accordion.php":"986baed18c174cc59523b49946f19c18","app\/Blocks\/NotificationBanner.php":"b0c0d71623d339eec4fc0392628202e5","app\/Blocks\/iBlock.php":"fb0cc3f4b55653e44e6f3268c62cea8e","app\/Blocks\/Button.php":"617d9e3be721d2ed486729ed5589bd34","app\/load.php":"a4f9b28a74fb6528b579d7b50938aced","app\/di.php":"fbc8c0cf5d51882f814d9e3a9edb4813","app\/BlockCategory.php":"96062756aec8f8c0ac62aeb742683535","app\/Options.php":"ed1ec0f3173d0f0c08eb92c2c35feb06","app\/BlockController.php":"3c99866fdc2a74b3e39958a7591eb5ee","index.php":"f601a517bea5cb1726fbaad021bc82b6","spec\/blocks\/details.spec.php":"7622ab8ff585d1fe3b7fc5f8eb650b8f","spec\/blocks\/notification_banner.spec.php":"b290162dd480e8296d6da4300eb02049","spec\/blocks\/accordion.spec.php":"479b91a049f5ebc17d137c91641b0eb6","spec\/blocks\/inset_text.spec.php":"ea301c7cbb898d25720b328e803a939f","spec\/blocks\/warning_text.spec.php":"0526586c5e5e9b4347ac8349e65ff4eb","spec\/blocks\/button.spec.php":"cb72508f9f8c2714fcd40f7720ca67b6","spec\/block_category.spec.php":"e86613f05b6946bbf4b9d4c80d12c303","spec\/options.spec.php":"9d1b130c5f025ca4066074158ee48e4b","spec\/block_controller.spec.php":"e7af5ba57db5557e73963e33ea123101","templates\/details.php":"9fcecf64b82d07f57abcb5bb0425a9d5","templates\/accordion.php":"6de8b940f86107693bf7a8e7c09aaf0b","templates\/notification_banner.php":"855648e14c87f7ff9405fd5f0dbecc6f","templates\/warning_text.php":"3cccd6d65c798e3a92fd745310f1c475","templates\/inset_text.php":"3e46980d3bdf2c2f842718b062dbbe7a","templates\/button.php":"737d9925258589c682fcd45af3beb57a","peridot.php":"6a778bf65a85942f2643a787215222a6","\/private\/var\/folders\/d8\/82xv262x6rnftct1fnngv65w0000gr\/T\/PHP CS Fixertemp_folder6\/templates\/accordion.php":"5624488a612dd6cf07ba2c5d4f78de10","\/private\/var\/folders\/d8\/82xv262x6rnftct1fnngv65w0000gr\/T\/PHP CS Fixertemp_folder861\/templates\/accordion.php":"5624488a612dd6cf07ba2c5d4f78de10","\/private\/var\/folders\/d8\/82xv262x6rnftct1fnngv65w0000gr\/T\/PHP CS Fixertemp_folder4\/templates\/accordion.php":"6de8b940f86107693bf7a8e7c09aaf0b","\/private\/var\/folders\/d8\/82xv262x6rnftct1fnngv65w0000gr\/T\/PHP CS Fixertemp_folder1659\/templates\/accordion.php":"6de8b940f86107693bf7a8e7c09aaf0b","\/private\/var\/folders\/d8\/82xv262x6rnftct1fnngv65w0000gr\/T\/PHP CS Fixertemp_folder1321\/templates\/accordion.php":"6de8b940f86107693bf7a8e7c09aaf0b"}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please add a new commit to delete this file and put it in .gitignore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

snim2
snim2 reviewed Sep 9, 2024
View reviewed changes
CHANGELOG.md

## [Unreleased]
### Fixed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I think this should be:

### Changed
- Upgrade Iguana for PHP 8 compatibility

### Fixed
- Accordion ACF warning that ACF now automatically escapes unsafe HTML

Did the Iguana upgrade happen in a different PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I think this should be:

### Changed
- Upgrade Iguana for PHP 8 compatibility

### Fixed
- Accordion ACF warning that ACF now automatically escapes unsafe HTML

Did the Iguana upgrade happen in a different PR?

@snim2 yes, one made by Patrick

snim2
snim2 requested changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@snim2 snim2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments

@serena-piccioni serena-piccioni merged commit 8b62d19 into main Sep 9, 2024
5 checks passed
@serena-piccioni serena-piccioni deleted the fix/accordion-acf-warning branch September 9, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snim2 snim2 snim2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serena-piccioni @snim2