Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple send integration tests #139

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

mec
Copy link
Contributor

@mec mec commented Apr 5, 2024

We have out integration tests working well for the previews and it
follows that we can use them to test sending emails.

Whilst we cannot 'check' that Notify will do the right thing, we can
check that things appear to have gone well.

These tests use a real Notify account and the results of sending the
email will show up in the Notify console. No email is actually sent as
we use a test API key.

This work only includes the tests it does not run them in GitHub
actions, that will come next.

You can run them locally with a Notify API key:

docker build --build-arg RAILS_VERSION=5.2.8.1 . -t rails-5

docker run --rm -e "NOTIFY_API_KEY=$NOTIFY_API_KEY" rails-5:latest bin/rails test

We have out integration tests working well for the previews and it
follows that we can use them to test sending emails.

Whilst we cannot 'check' that Notify will do the right thing, we can
check that things appear to have gone well.

These tests use a real Notify account and the results of sending the
email will show up in the Notify console. No email is actually sent as
we use a test API key.

This work only includes the tests it does not run them in GitHub
actions, that will come next.

You can run them locally with a Notify API key:

```
docker build --build-arg RAILS_VERSION=5.2.8.1 . -t rails-5

docker run --rm -e "NOTIFY_API_KEY=$NOTIFY_API_KEY" rails-5:latest bin/rails test
```
@mec mec merged commit b5b17fe into main Apr 5, 2024
3 of 6 checks passed
@mec mec deleted the add-simple-send-integration-tests branch April 5, 2024 14:23
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8571274221

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.671%

Totals Coverage Status
Change from base Build 8571103320: 0.0%
Covered Lines: 303
Relevant Lines: 304

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants