Fix builds for Rails integration tests #158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10418343681Details
💛 - Coveralls |
mec
force-pushed
the
chore/update-ci-integration-test-env
branch
3 times, most recently
from
d681677 to
b8f97d6
Compare
pezholio
reviewed
Aug 1, 2024
A couple of things changed recently that broke these for us: - Rails 7.2 beta dropped support for Ruby < 3.1 - ffi dropped support for Rubygems < 3.3.22 We have updated Rubygems and bundler to new enough versions to compile the ffi gem. We also had to add the build-essential package into a later build step as ffi seems to get built a second time - this is possibly incorrect and will need looking into. We should possibly decide to at least drop testing for end of life versions: - Ruby 2.7.8 - Rails 5.2.8.1
mec
force-pushed
the
chore/update-ci-integration-test-env
branch
from
b8f97d6 to
4839aa9
Compare
|
Classic! So in the time it's taken me to get to this, Rails 7.2 is out so we need to come back to this! |
mec
force-pushed
the
chore/update-ci-integration-test-env
branch
from
8deb203 to
4839aa9
Compare
It’s end of life now, so we should stop support.
`2.7.x` is end of life now, so let’s run integration tests and develop against the lowest supported version of Ruby
We are dropping integration test for Rails 5 as it becomes more effort to support them than there is value in having it.
|
Superseded by #160 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of things changed recently that broke these for us:
To fix this we have switched from fetching the Rails version to
supplying them in the GitHub actions, at least until Rails 7.2 is out.
We have also updated Rubygems and bundler to new enough versions to
compile the ffi gem.
We also had to add the build-essential package into a later build step
as ffi seems to get built a second time - this is possibly incorrect and
will need looking into.
We should possibly decide to at least drop testing for end of life versions: