Run integration tests after workflow run #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 13975687207Details
💛 - Coveralls |
It turns out that `pull_request_target` runs regardless of permissions, as code that is run is considered to be trusted, which we don’t necessarily want. Changing this to `workflow_run` ensures that the action is ONLY run after the rest of the CI runs (which will need to be accepted for external contributions). Like `pull_request_target`, `workflow_run` triggers have access to secrets, but won’t get triggered until the other actions are approved and have run.
pezholio
force-pushed
the
run-integration-tests-after-workflow-run
branch
from
9457f6d to
95ffe87
Compare
dragon-dxw
approved these changes
Mar 20, 2025
Running Zizmor, we had some suggestions made to tighten security
dragon-dxw
requested changes
Mar 20, 2025
There was a problem hiding this comment.
Having a rethink whilst re-reading https://woodruffw.github.io/zizmor/audits/#dangerous-triggers
pezholio
force-pushed
the
run-integration-tests-after-workflow-run
branch
2 times, most recently
from
426add2 to
06c03ed
Compare
|
Annoyingly, we need to access secrets to run the integration tests, but this approach is more secure than the one we added last time |
dragon-dxw
approved these changes
Mar 20, 2025
pezholio
force-pushed
the
run-integration-tests-after-workflow-run
branch
from
06c03ed to
2563dfa
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that
pull_request_targetruns regardless of permissions, as code that is run is considered to be trusted, which we don’t necessarily want.Changing this to
workflow_runensures that the action is ONLY run after the rest of the CI runs (which will need to be accepted for external contributions). Likepull_request_target,workflow_runtriggers have access to secrets, but won’t get triggered until the other actions are approved and have run.