[OTE-154] Update CLOB IsSingleClobMsgTx to not take ctx (#1059)

dydxprotocol · Feb 8, 2024 · c79377e · c79377e
1 parent d3273b1
commit c79377e
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/protocol/app/ante/gas.go b/protocol/app/ante/gas.go
@@ -27,7 +27,7 @@ func (dec FreeInfiniteGasDecorator) AnteHandle(
 	simulate bool,
 	next sdk.AnteHandler,
 ) (newCtx sdk.Context, err error) {
-	isSingleClobMsgTx, err := clobante.IsSingleClobMsgTx(ctx, tx)
+	isSingleClobMsgTx, err := clobante.IsSingleClobMsgTx(tx)
 	if err != nil {
 		return ctx, err
 	}

diff --git a/protocol/x/clob/ante/ante_wrapper.go b/protocol/x/clob/ante/ante_wrapper.go
@@ -27,7 +27,7 @@ func (anteWrapper SingleMsgClobTxAnteWrapper) AnteHandle(
 	simulate bool,
 	next sdk.AnteHandler,
 ) (sdk.Context, error) {
-	isSingleClobMsgTx, err := IsSingleClobMsgTx(ctx, tx)
+	isSingleClobMsgTx, err := IsSingleClobMsgTx(tx)
 	if err != nil {
 		return ctx, err
 	}

diff --git a/protocol/x/clob/ante/clob.go b/protocol/x/clob/ante/clob.go
@@ -51,7 +51,7 @@ func (cd ClobDecorator) AnteHandle(
 
 	// Ensure that if this is a clob message then that there is only one.
 	// If it isn't a clob message then pass to the next AnteHandler.
-	isSingleClobMsgTx, err := IsSingleClobMsgTx(ctx, tx)
+	isSingleClobMsgTx, err := IsSingleClobMsgTx(tx)
 	if err != nil {
 		return ctx, err
 	}
@@ -141,7 +141,7 @@ func (cd ClobDecorator) AnteHandle(
 // IsSingleClobMsgTx returns `true` if the supplied `tx` consist of a single clob message
 // (`MsgPlaceOrder` or `MsgCancelOrder`). If `msgs` consist of multiple clob messages,
 // or a mix of on-chain and clob messages, an error is returned.
-func IsSingleClobMsgTx(ctx sdk.Context, tx sdk.Tx) (bool, error) {
+func IsSingleClobMsgTx(tx sdk.Tx) (bool, error) {
 	msgs := tx.GetMsgs()
 	var hasMessage = false
 

diff --git a/protocol/x/clob/ante/clob_test.go b/protocol/x/clob/ante/clob_test.go
@@ -283,10 +283,9 @@ func TestIsClobTransaction(t *testing.T) {
 			err := builder.SetMsgs(tc.msgs...)
 			require.NoError(t, err)
 			tx := builder.GetTx()
-			ctx, _, _ := sdktest.NewSdkContextWithMultistore()
 
 			// Invoke the function under test.
-			result, err := ante.IsSingleClobMsgTx(ctx, tx)
+			result, err := ante.IsSingleClobMsgTx(tx)
 
 			// Assert the results.
 			require.Equal(t, tc.expectedResult, result)