-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable swagger in dev and staging. #1278
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThese updates introduce Swagger support for the application, allowing for enhanced API documentation and testing capabilities. This is achieved by setting a configuration flag to enable Swagger in both development and local testnet environments. Additionally, the update includes an adjustment to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (2)
- protocol/testing/testnet-dev/dev.sh (1 hunks)
- protocol/testing/testnet-local/local.sh (1 hunks)
Path-based instructions used (2)
protocol/testing/testnet-local/local.sh (1)
**/**
:
Do not include a walkthrough. For all comments on line changes that are longer than 15 lines, add a prefix to the comment of what lines you are commenting on (for example: "The changes from lines 100 to 200...". Add your comment to be on the last 15 lines of the chunk rather than adding your comment to the entire chunk.protocol/testing/testnet-dev/dev.sh (1)
**/**
:
Do not include a walkthrough. For all comments on line changes that are longer than 15 lines, add a prefix to the comment of what lines you are commenting on (for example: "The changes from lines 100 to 200...". Add your comment to be on the last 15 lines of the chunk rather than adding your comment to the entire chunk.
Additional comments not posted (4)
protocol/testing/testnet-local/local.sh (2)
180-181: Enabling Swagger by setting
.api.swagger
totrue
is correctly implemented and aligns with the PR's objectives. Ensure that all dependent services and scripts are aware of this new configuration to avoid any unexpected behavior.
179-179: Consider quoting variables in shell scripts to prevent globbing and word splitting, enhancing the robustness and reliability of the script. For example, when referencing variables, use
"$VARIABLE"
instead of$VARIABLE
.protocol/testing/testnet-dev/dev.sh (2)
214-215: Enabling Swagger by setting
.api.swagger
totrue
is correctly implemented and aligns with the PR's objectives for the development environment. Ensure that all dependent services and scripts are aware of this new configuration to avoid any unexpected behavior.
213-213: Consider quoting variables in shell scripts to prevent globbing and word splitting, enhancing the robustness and reliability of the script. For example, when referencing variables, use
"$VARIABLE"
instead of$VARIABLE
.
Changelist
Update the setup for dev/staging containers to enable swagger.
Test Plan
N/A
Author/Reviewer Checklist
state-breaking
label.indexer-postgres-breaking
label.PrepareProposal
orProcessProposal
, manually add the labelproposal-breaking
.feature:[feature-name]
.backport/[branch-name]
.refactor
,chore
,bug
.