Bump slinky sidecar, re-enabled volatile market #1345
Conversation
WalkthroughThe recent updates involve the uncommenting of the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Actionable comments outside the diff hunks (3)
protocol/testing/testnet-local/local.sh (1)
Line range hint
110-116: Wrap variables in double quotes to prevent globbing and word splitting.- echo "${MNEMONICS[$i]}" | dydxprotocold keys add "${MONIKERS[$i]}" --recover --keyring-backend=test --home "$VAL_HOME_DIR" + echo "${MNEMONICS[$i]}" | dydxprotocold keys add "${MONIKERS[$i]}" --recover --keyring-backend=test --home "$VAL_HOME_DIR"protocol/testing/testnet-dev/dev.sh (1)
Line range hint
142-148: Wrap variables in double quotes to prevent globbing and word splitting.- echo "${MNEMONICS[$i]}" | dydxprotocold keys add "${MONIKERS[$i]}" --recover --keyring-backend=test --home "$VAL_HOME_DIR" + echo "${MNEMONICS[$i]}" | dydxprotocold keys add "${MONIKERS[$i]}" --recover --keyring-backend=test --home "$VAL_HOME_DIR"protocol/testing/testnet-staging/staging.sh (1)
Line range hint
196-202: Wrap variables in double quotes to prevent globbing and word splitting.- echo "${MNEMONICS[$i]}" | dydxprotocold keys add "${MONIKERS[$i]}" --recover --keyring-backend=test --home "$VAL_HOME_DIR" + echo "${MNEMONICS[$i]}" | dydxprotocold keys add "${MONIKERS[$i]}" --recover --keyring-backend=test --home "$VAL_HOME_DIR"
Review Status
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
protocol/docker-compose.ymlis excluded by!**/*.yml
Files selected for processing (3)
- protocol/testing/testnet-dev/dev.sh (1 hunks)
- protocol/testing/testnet-local/local.sh (1 hunks)
- protocol/testing/testnet-staging/staging.sh (1 hunks)
Additional Context Used
Path-based Instructions (3)
protocol/testing/testnet-local/local.sh (1)
Pattern
**/**: Do not include a walkthrough. For all comments on line changes that are longer than 15 lines, add a prefix to the comment of what lines you are commenting on (for example: "The changes from lines 100 to 200...". Add your comment to be on the last 15 lines of the chunk rather than adding your comment to the entire chunk.protocol/testing/testnet-dev/dev.sh (1)
Pattern
**/**: Do not include a walkthrough. For all comments on line changes that are longer than 15 lines, add a prefix to the comment of what lines you are commenting on (for example: "The changes from lines 100 to 200...". Add your comment to be on the last 15 lines of the chunk rather than adding your comment to the entire chunk.protocol/testing/testnet-staging/staging.sh (1)
Pattern
**/**: Do not include a walkthrough. For all comments on line changes that are longer than 15 lines, add a prefix to the comment of what lines you are commenting on (for example: "The changes from lines 100 to 200...". Add your comment to be on the last 15 lines of the chunk rather than adding your comment to the entire chunk.
Additional comments not posted (6)
protocol/testing/testnet-local/local.sh (2)
104-104: Ensure theupdate_genesis_use_test_volatile_marketfunction call is properly tested in the local environment.
Line range hint
7-7: Ensure that./genesis.shis correctly sourced and accessible from the script's execution context.protocol/testing/testnet-dev/dev.sh (2)
138-138: Ensure theupdate_genesis_use_test_volatile_marketfunction call is properly tested in the dev environment.
Line range hint
6-6: Ensure that./genesis.shis correctly sourced and accessible from the script's execution context.protocol/testing/testnet-staging/staging.sh (2)
192-192: Ensure theupdate_genesis_use_test_volatile_marketfunction call is properly tested in the staging environment.
Line range hint
6-6: Ensure that./genesis.shis correctly sourced and accessible from the script's execution context.
|
https://github.com/Mergifyio backport release/protocol/v5.x |
✅ Backports have been created
|
(cherry picked from commit 0128629)
Changelist
Bumps slinky sidecar to use
v0.3.2docker image which allows us to re-enable the volatile market.Will need to be updated in dev deployments. I don't have access to that.
Test Plan
Ran localnet and got prices for TEST/USD.
Author/Reviewer Checklist
state-breakinglabel.indexer-postgres-breakinglabel.PrepareProposalorProcessProposal, manually add the labelproposal-breaking.feature:[feature-name].backport/[branch-name].refactor,chore,bug.