Fix sidecar version checker

[chenyaoy]

Changelist

Sidecar version can return tests/integration/v1.2.0, which caused an error when trying to parse that into a semantic version. Handle this case.

Test Plan

[Describe how this PR was tested (if applicable)]

Author/Reviewer Checklist

• If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
• If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
• If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
• If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
• If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
• Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

• New Features

  • Enhanced version checking logic for the sidecar service to correctly handle version strings with or without prefixes.
  • Updated the Slinky sidecar service to version v1.1.0, potentially introducing new features and improvements.

• Bug Fixes

  • Improved handling of version strings in the version checking process.

• Tests

  • Added new test cases to ensure the version checking logic works correctly with various version string formats.

[coderabbitai]

Walkthrough

This pull request introduces modifications to the Slinky sidecar version checking mechanism. The changes include updating the version extraction logic in the sidecar_version_checker.go file to handle version strings with prefixes more robustly. Corresponding test cases are added to validate the new version parsing behavior. Additionally, the docker-compose.yml file is updated to use a newer version of the Slinky sidecar service (v1.1.0).

Changes

File	Change Summary
protocol/daemons/slinky/client/sidecar_version_checker.go	Modified CheckSidecarVersion method to extract version number using strings.LastIndex, handling version strings with prefixes
protocol/daemons/slinky/client/sidecar_version_checker_test.go	Added two new test cases to verify version parsing with and without "v" prefix
protocol/docker-compose.yml	Updated Slinky sidecar image version from v1.0.13 to v1.1.0

Possibly related PRs

• [TRA-721] Enforce sidecar versions #2491: PR that enforces sidecar versions and includes changes to the SidecarVersionChecker

Suggested labels

protocol

Suggested reviewers

• vincentwschau
• Eric-Warehime

Poem

🐰 A rabbit's tale of version might,
Slinky's checker now shines so bright!
Prefixes dance, versions align,
With code so clean, it's simply fine!
Hop along, version control's delight! 🚀

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 59abb7b and 4a56c60.

📒 Files selected for processing (3)

• protocol/daemons/slinky/client/sidecar_version_checker.go (2 hunks)
• protocol/daemons/slinky/client/sidecar_version_checker_test.go (2 hunks)
• protocol/docker-compose.yml (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• protocol/docker-compose.yml

🔇 Additional comments (6)

protocol/daemons/slinky/client/sidecar_version_checker.go (3)

6-6: Import usage looks good.
You correctly introduced the strings import to facilitate substring parsing in the subsequent code.

---

55-59: Substring extraction approach is appropriate.
The use of strings.LastIndex to find the last slash ("/") helps handle various prefix formats. This pragmatic approach meets the PR’s objective of removing unexpected prefixes like tests/integration/.

---

60-60: Version parsing logic is solid.
Ensuring that versionStr is updated before calling version.NewVersion addresses the issue of semver parsing failures. The error handling also looks correct.

protocol/daemons/slinky/client/sidecar_version_checker_test.go (3)

5-5: Import statement rationale is clear.
The strings import is used to validate that MinSidecarVersion starts with "v". This test approach enforces consistency.

---

50-64: Test coverage with removed prefix is thorough.
Validating that the code handles MinSidecarVersion minus its "v" prefix ensures your solution correctly manages versions with unexpected prefixes.

---

66-78: Tests for 'tests/integration' prefix confirm real-world scenario.
By verifying tests/integration/v1.2.0, you ensure robust handling of sidecar versions that contain directory-like prefixes.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[chenyaoy]

@Mergifyio backport release/protocol/v8.x

[mergify]

backport release/protocol/v8.x

✅ Backports have been created

• #2672 Fix sidecar version checker (backport #2671) has been created for branch release/protocol/v8.x