Complete GitHub Sponsors integration - Add badge and composer funding #75
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR completes the GitHub Sponsors integration by adding the sponsors badge to the README and the funding field to composer.json, building on the .github/FUNDING.yml file added in PR #74. Additionally, it removes the phpcoverage configuration from the CI workflow.
- Added GitHub Sponsors badge to README.md
- Added funding section to composer.json with GitHub Sponsors URL
- Removed
phpcoverage: trueconfiguration from CI workflow
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| composer.json | Added funding section with GitHub Sponsors URL |
| README.md | Added Sponsors badge after codecov badge |
| .github/workflows/ci.yml | Removed phpcoverage configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| [](https://github.com/dynamic/silverstripe-geocoder/actions/workflows/ci.yml) | ||
| [](https://codecov.io/gh/dynamic/silverstripe-geocoder) | ||
| [](https://github.com/sponsors/dynamic) |
There was a problem hiding this comment.
The Sponsors badge is placed after the codecov badge, but according to the PR description, it should be placed after the license badge. The license badge appears later in the README (line 10 shows Total Downloads, suggesting license badge is further down). Consider moving this badge to its intended position after the license badge.
| jobs: | ||
| ci: | ||
| name: CI | ||
| uses: silverstripe/gha-ci/.github/workflows/ci.yml@v1 |
There was a problem hiding this comment.
The removal of phpcoverage: true configuration is not mentioned in the PR description or title, which focuses solely on GitHub Sponsors integration. This change appears unrelated to the stated purpose of the PR and should either be documented in the PR description or moved to a separate PR for clarity.
| uses: silverstripe/gha-ci/.github/workflows/ci.yml@v1 | |
| uses: silverstripe/gha-ci/.github/workflows/ci.yml@v1 | |
| with: | |
| phpcoverage: true |
This PR completes the GitHub Sponsors integration that was partially implemented in PR #74.
Changes
fundingfield to composer.json pointing to https://github.com/sponsors/dynamicContext
PR #74 added the
.github/FUNDING.ymlfile but did not update the README badge or composer.json funding field. This PR completes the integration to match the other repositories in the organization.