Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disassemble: approximate output formatting of objdump #59

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

batuzovk
Copy link
Contributor

Make output formatting more similar to that of objdump. It makes the result prettier, and opens possibilities for direct output comparison.

Some other changes that happened while adjusting formatting:

  • Instruction decoder is created with dummy buffer. The buffer is not used, so making an actual one does nothing.
  • Fixed a bug that caused disassemble to freeze if it encountered an invalid (in its understanding) instruction. No_Entry has size 0, so crtAddr didn't advance.

Copy link
Collaborator

@hainest hainest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for getting to this so late. I somehow completely missed it!

disassemble/disassemble.cpp Show resolved Hide resolved
disassemble/disassemble.cpp Show resolved Hide resolved
Make output formatting more similar to that of objdump.
It makes the result prettier, and opens possibilities for
direct output comparison.
@batuzovk batuzovk force-pushed the objdump-formatting branch from a40ea76 to 72a0e62 Compare June 12, 2024 10:53
@hainest hainest merged commit 0cd46f5 into dyninst:master Jun 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants