Skip to content

Conversation

@vanillajonathan
Copy link
Contributor

Use dedicated shortcut widgets instead of boxes and labels.

Use dedicated shortcut widgets instead of boxes and labels.
Copy link
Owner

@dynobo dynobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the contribution, but since ShortcutsSection is deprecated, it feels like not sustainable to introduce it, when it already is clear, that it has to be removed again sooner or later. What do you think?

@vanillajonathan
Copy link
Contributor Author

Yes, the widgets are deprecated because they have been moved from GTK to Adwaita in Adwaita v1.8.

I think we should merge it, then when the new version of Adwaita is released, we migrate to the Adw widgets which have a similar API and will be very easy migrate over to.

@dynobo
Copy link
Owner

dynobo commented Aug 19, 2025

[...] when the new version of Adwaita is released, we migrate to the Adw widgets which have a similar API and will be very easy migrate over to.

Do you have any link to the documentation for those Adwaita widgets?

I do not want to introduce code into the project, which is already deprecated. This also follows GTK's recommendation.

But if Adwaita has widgets for displaying key bindings, I'd happily consider using those!

@vanillajonathan
Copy link
Contributor Author

Yes, the documentation is at https://gnome.pages.gitlab.gnome.org/libadwaita/doc/main/class.ShortcutsDialog.html but new widgets will be introduced in Adwaita 1.8.

@dynobo
Copy link
Owner

dynobo commented Aug 19, 2025

Thanks, @vanillajonathan. Let's then wait for the Adwaita 1.8 final release, and after that switch directly to the adwaita shortcut widgets.

@dynobo
Copy link
Owner

dynobo commented Oct 17, 2025

This PR got superseeded by #35, which updates to GTK 4.20 with Libadwaita 1.8 and implements the ShortcutsDialog.

@dynobo dynobo closed this Oct 17, 2025
@vanillajonathan vanillajonathan deleted the patch-1 branch October 18, 2025 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants