Skip to content

fix(inotify): correct event type for symlinks #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025

Conversation

DanielCodesphere
Copy link
Contributor

Use the correct path type for symlinks instead of always using file.
This might have to be fixed for other backends as well, but i didn't test that.

@e-dant e-dant changed the base branch from release to next May 26, 2025 21:26
@e-dant
Copy link
Owner

e-dant commented May 26, 2025

Thank you, this looks great!

Some (trivial, non-blocking) notes which I can play with in next:

  • pathof is relatively expensive, since paths can be large, and it performs a hash. Cutting that down to (usually) once per path in the body of the function would be nice.
  • The null checks on in can be avoided, since they are made by the caller do_ev_recv.

@e-dant e-dant merged commit fec3ff2 into e-dant:next May 26, 2025
9 checks passed
@e-dant e-dant mentioned this pull request May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants