Skip to content

Add a simple fix to detect aws-sdk #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnhaley81 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a simple fix to detect aws-sdk #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ function getHandlerFilePath(servicePath, handler) {
function resolveToBaseModuleGlob(file) {
const relative = path.relative(process.cwd(), file);
const match = relative.match(/^((\.\.\/)*node_modules\/\S+?\/)/);
if (match) {
if (match && !match[1].endsWith('aws-sdk')) {
Copy link
Owner

@e-e-e e-e-e Jul 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will still miss aws-sdk imports where the library is imported modularly eg: aws-sdk/clients/s3. Would it be possible for you to add a test to confirm that this works?
If you don't have time I am happy to merge this as is, as it does move us closer to resolving that issue.

return `${match[1]}**`;
}
return relative;
Expand Down