Skip to content

Commit

Permalink
build(pybind11): bump minimum version to v2.10.0
Browse files Browse the repository at this point in the history
  • Loading branch information
e-kwsm committed Nov 13, 2023
1 parent dc0e223 commit ca86b60
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions python/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ if (NOT TARGET Python::Module)
find_package(Python COMPONENTS Interpreter Development REQUIRED)
endif()

find_package(pybind11 2.6.0 CONFIG)
find_package(pybind11 2.10.0 CONFIG)
if (NOT TARGET pybind11::pybind11)
message(STATUS "Suitable pybind11 could not be located, building pybind11 instead.")

Expand All @@ -22,14 +22,14 @@ if (NOT TARGET pybind11::pybind11)
FetchContent_Declare(
pybind11
GIT_REPOSITORY https://github.com/pybind/pybind11.git
GIT_TAG v2.6.0 # sync below!
GIT_TAG v2.10.0 # sync below!
# GIT_REPOSITORY https://github.com/ValeevGroup/pybind11.git
# GIT_TAG 80d452484c5409444b0ec19383faa84bb7a4d351 # v2.4.3
# FIND_PACKAGE_ARGS 2.4.3 CONFIG # CMake 3.24 integrates find_package() call above into FC_Declare
)

FetchContent_MakeAvailable(pybind11)
set(pybind11_VERSION "2.6.0") # getting the fetched version isn't reliable from ${CMAKE_PROJECT_VERSION}), so sync explicitly from tag above
set(pybind11_VERSION "2.10.0") # getting the fetched version isn't reliable from ${CMAKE_PROJECT_VERSION}), so sync explicitly from tag above
endif()

if (pybind11_VERSION VERSION_LESS_EQUAL 2.5.0)
Expand Down

0 comments on commit ca86b60

Please sign in to comment.