Skip to content

Commit

Permalink
♻️ Display the values that will change (UUID, major, minor)
Browse files Browse the repository at this point in the history
Instead of the statically coded name/identifier
This involved changing the text size so that we could see the UUID
I wonder if we should make the UUID the subtitle and the major:minor the title

Testing done:
e-mission/e-mission-docs#1062 (comment)
  • Loading branch information
shankari committed Mar 29, 2024
1 parent 8f9b130 commit 58b2b0a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions www/js/bluetooth/BluetoothCard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ const BluetoothCard = ({ device, isClassic, isScanningBLE }: Props) => {
return (
<Card style={{ backgroundColor: bgColor, ...cardStyles.card }}>
<Card.Title
title={`Name: ${device.identifier}`}
titleVariant="titleLarge"
subtitle={`UUID: ...${device.uuid.slice(-13)}`} // e.g.,
title={`UUID: ${device.uuid}`}
titleVariant="titleSmall"
subtitle={`Configured major ${device.major} and minor ${device.minor}`} // e.g.,
left={() => <List.Icon icon={device.in_range ? 'access-point' : 'access-point-off'} />}
/>
</Card>
Expand Down
2 changes: 1 addition & 1 deletion www/js/bluetooth/BluetoothScanPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ const BluetoothScanPage = ({ ...props }: any) => {
/>
<Button disabled={!(newUUID)}
onPress={() => addNewUUID(newUUID, newMajor, newMinor)}>
Add
Add New Beacon To Scan
</Button>
</SafeAreaView>
</Modal>
Expand Down

0 comments on commit 58b2b0a

Please sign in to comment.