Skip to content

Commit

Permalink
⬆️ Bump up the core versions
Browse files Browse the repository at this point in the history
- `cordova-android` to 12
- `cordova-plugin-file` to 8.0.0
- Remove SDK version overrides and go with the cordova-android defaults

Note that this will not work until
e-mission/e-mission-data-collection#207
is merged

#1016 (comment)
  • Loading branch information
shankari committed Aug 19, 2023
1 parent 8471472 commit faa1cfa
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
3 changes: 0 additions & 3 deletions config.cordovabuild.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
<preference name="webviewbounce" value="false" />
<preference name="UIWebViewBounce" value="false" />
<preference name="DisallowOverscroll" value="true" />
<preference name="android-minSdkVersion" value="22" />
<preference name="BackupWebStorage" value="none" />
<preference name="emSensorDataCollectionProtocolApprovalDate" value="2016-07-14" />
<preference name="GradlePluginGoogleServicesEnabled" value="true" />
Expand Down Expand Up @@ -48,8 +47,6 @@
</platform>
<platform name="android">
<hook src="hooks/before_build/android/android_copy_locales.js" type="before_build" />
<preference name="android-minSdkVersion" value="23" />
<preference name="android-targetSdkVersion" value="32" />
<preference name="AndroidLaunchMode" value="singleInstance"/>
<preference name="AndroidXEnabled" value="true" />
<preference name="GradlePluginKotlinEnabled" value="true" />
Expand Down
4 changes: 2 additions & 2 deletions package.cordovabuild.json
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@
"chart.js": "^4.3.0",
"chartjs-adapter-luxon": "^1.3.1",
"chartjs-plugin-annotation": "^3.0.1",
"cordova-android": "11.0.0",
"cordova-android": "12.0.0",
"cordova-ios": "6.2.0",
"cordova-plugin-advanced-http": "3.3.1",
"cordova-plugin-androidx-adapter": "1.1.3",
Expand All @@ -133,7 +133,7 @@
"cordova-plugin-em-unifiedlogger": "git+https://github.com/e-mission/cordova-unified-logger.git#v1.3.6",
"cordova-plugin-em-usercache": "git+https://github.com/e-mission/cordova-usercache.git#v1.1.6",
"cordova-plugin-email-composer": "git+https://github.com/katzer/cordova-plugin-email-composer.git#0.10.1",
"cordova-plugin-file": "7.0.0",
"cordova-plugin-file": "8.0.0",
"cordova-plugin-inappbrowser": "5.0.0",
"cordova-plugin-ionic-keyboard": "2.2.0",
"cordova-plugin-ionic-webview": "5.0.0",
Expand Down

0 comments on commit faa1cfa

Please sign in to comment.